FINERACT-2216: add github project metadata - #4464
Conversation
adamsaghy
left a comment
There was a problem hiding this comment.
Please attach the required "Apache" licence ;)
|
There's nowhere to add it. The See https://github.com/apache/infrastructure-asfyaml/blob/main/asfyaml/feature/github/__init__.py#L57 GitHub derives the project license from the |
|
@meonkeys Okay, but you need to add this file to the exclusion list then: |
|
Oh I see! Ok, will do. I'll also sign my commits... I'm trying to get in that habit too |
417dd0f to
dd77e07
Compare
1. Link to project homepage at https://fineract.apache.org 2. Add some tags/labels/topics See also: * https://github.com/apache/infrastructure-asfyaml#repo_meta * https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/classifying-your-repository-with-topics
dd77e07 to
dd52c7e
Compare
|
LGTM |
|
Oh cool and it already worked. Looks great. Thanks guys! |

See also:
Description
See https://issues.apache.org/jira/browse/FINERACT-2216
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.