FINERACT-2181: Fix the interest calculation for non disbursed loan - #4864
Merged
adamsaghy merged 1 commit intoJul 31, 2025
Merged
Conversation
budaidev
force-pushed
the
FINERACT-2181/fix-interest-calc-non-disbursed-loan
branch
4 times, most recently
from
July 18, 2025 09:22
1be8f9a to
0d79c59
Compare
budaidev
marked this pull request as ready for review
July 18, 2025 12:54
galovics
approved these changes
Jul 18, 2025
budaidev
force-pushed
the
FINERACT-2181/fix-interest-calc-non-disbursed-loan
branch
from
July 20, 2025 19:35
0d79c59 to
3af675c
Compare
Contributor
|
@budaidev Please take a look on the failing tests cases and please change from FINERACT-2181 to FINERACT-2326 the PR title and commit message! |
adamsaghy
force-pushed
the
FINERACT-2181/fix-interest-calc-non-disbursed-loan
branch
2 times, most recently
from
July 31, 2025 07:51
ec1cec2 to
78e8774
Compare
adamsaghy
force-pushed
the
FINERACT-2181/fix-interest-calc-non-disbursed-loan
branch
from
July 31, 2025 13:30
78e8774 to
48c669f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.