FINERACT-2311: Add GET API for buy down fees related information - #4882

oleksii-novikov-onix · 2025-07-24T08:48:36Z

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

adamsaghy

Please take a look on my request!

adamsaghy · 2025-07-30T16:42:06Z

@oleksii-novikov-onix Please check and fix the failed tests!

…etails

oleksii-novikov-onix · 2025-07-30T20:33:46Z

@oleksii-novikov-onix Please check and fix the failed tests!

Done

adamsaghy

LGTM

oleksii-novikov-onix marked this pull request as ready for review July 24, 2025 12:52

oleksii-novikov-onix force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch 4 times, most recently from 796d613 to d91c0c2 Compare July 28, 2025 11:51

MarianaDmytrivBinariks force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch 2 times, most recently from 05aeabb to 2910221 Compare July 29, 2025 09:41

adamsaghy reviewed Jul 29, 2025

View reviewed changes

Comment thread ...n/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanBuyDownFeeApiResource.java

adamsaghy requested changes Jul 29, 2025

View reviewed changes

oleksii-novikov-onix force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch from 2910221 to 1b6b0b1 Compare July 29, 2025 17:06

oleksii-novikov-onix marked this pull request as draft July 29, 2025 17:11

MarianaDmytrivBinariks force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch from ba42e39 to 7dd52f3 Compare July 30, 2025 08:59

adamsaghy marked this pull request as ready for review July 30, 2025 09:00

MarianaDmytrivBinariks force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch 2 times, most recently from df733ac to b4cfeb5 Compare July 30, 2025 12:18

adamsaghy reviewed Jul 30, 2025

View reviewed changes

Comment thread ...main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java Outdated

adamsaghy reviewed Jul 30, 2025

View reviewed changes

Comment thread ...src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformService.java Outdated

adamsaghy reviewed Jul 30, 2025

View reviewed changes

Comment thread ...n/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanBuyDownFeeApiResource.java Outdated

adamsaghy reviewed Jul 30, 2025

View reviewed changes

Comment thread .../main/java/org/apache/fineract/portfolio/loanaccount/data/BuyDownFeeAmortizationDetails.java Outdated

oleksii-novikov-onix force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch from b4cfeb5 to a3478e4 Compare July 30, 2025 14:21

oleksii-novikov-onix requested a review from adamsaghy July 30, 2025 14:24

oleksii-novikov-onix force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch from a3478e4 to b1b9063 Compare July 30, 2025 15:08

oleksii-novikov-onix and others added 2 commits July 30, 2025 23:32

FINERACT-2311: Add GET API for buy down fees related information

65b867e

FINERACT-2311: added e2e tests for buy down fees fetch amortization d…

086e1c5

…etails

oleksii-novikov-onix force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch from b1b9063 to 086e1c5 Compare July 30, 2025 20:33

adamsaghy approved these changes Jul 31, 2025

View reviewed changes

adamsaghy merged commit 3e2684c into apache:develop Jul 31, 2025
39 checks passed

adamsaghy deleted the FINERACT-2311/buy-down-fees-fetch-amortization-details branch July 31, 2025 08:01

Navigation Menu

Uh oh!

FINERACT-2311: Add GET API for buy down fees related information - #4882