Skip to content

FINERACT-2326: Locale Validator shall accept all valid language codes - #4899

Merged
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2326/locale-validator-enhancement
Jul 28, 2025
Merged

FINERACT-2326: Locale Validator shall accept all valid language codes#4899
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2326/locale-validator-enhancement

Conversation

@adamsaghy

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@somasorosdpc somasorosdpc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy
adamsaghy force-pushed the FINERACT-2326/locale-validator-enhancement branch from 5b87f5e to 92d4006 Compare July 28, 2025 15:48
@adamsaghy
adamsaghy merged commit 52be537 into apache:develop Jul 28, 2025
39 checks passed
@adamsaghy
adamsaghy deleted the FINERACT-2326/locale-validator-enhancement branch July 28, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants