Skip to content

FINERACT-2124: Fix final income accrual calculation with multiple fee charges - #4909

Merged
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2124/fix-final-income-accrual-transaction-when-multiple-fee-charges-exist-on-instalment
Aug 5, 2025
Merged

FINERACT-2124: Fix final income accrual calculation with multiple fee charges#4909
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2124/fix-final-income-accrual-transaction-when-multiple-fee-charges-exist-on-instalment

Conversation

@mariiaKraievska

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@mariiaKraievska
mariiaKraievska force-pushed the FINERACT-2124/fix-final-income-accrual-transaction-when-multiple-fee-charges-exist-on-instalment branch from 20c0bb6 to 8bf9282 Compare July 31, 2025 10:02
@mariiaKraievska
mariiaKraievska force-pushed the FINERACT-2124/fix-final-income-accrual-transaction-when-multiple-fee-charges-exist-on-instalment branch from 8bf9282 to a6e5145 Compare July 31, 2025 10:14

@magyari-adam magyari-adam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariiaKraievska
mariiaKraievska marked this pull request as ready for review August 4, 2025 12:33
@adamsaghy
adamsaghy merged commit 0daf42e into apache:develop Aug 5, 2025
39 checks passed
@adamsaghy
adamsaghy deleted the FINERACT-2124/fix-final-income-accrual-transaction-when-multiple-fee-charges-exist-on-instalment branch August 5, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants