FINERACT-2326: Improve null-safety - #4944
Merged
Merged
Conversation
adamsaghy
force-pushed
the
FINERACT-2326/null-safety
branch
from
August 12, 2025 17:49
69e98aa to
34028a0
Compare
oleksii-novikov-onix
approved these changes
Aug 13, 2025
adamsaghy
force-pushed
the
FINERACT-2326/null-safety
branch
from
August 13, 2025 08:19
34028a0 to
1f17aed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of this PR, my intention was to achieve proper null safety in the InterestPeriod, RepaymentPeriod and ProgressiveEmiCalculator classes:
I have also modified the MathUtil class and added a new "nullToZero" method which accepts MathContext as parameter and set on the Money object!
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.