FINERACT-2326: add test Fineract API requests to README - #5051
Conversation
|
@adamsaghy could you please review this PR? Thank you |
|
I can... I've been editing docs a bunch lately. |
|
Thanks for your patch, @kengneruphine ! Please also review https://github.com/apache/fineract#pull-requests ... you need to create a JIRA ticket. Every Apache Fineract GitHub PR has an associated JIRA ticket and follows a naming convention. If you only change a few lines in the top-level readme I might still approve your patch, but it's just good practice to always create JIRA tickets and follow the PR naming convention. |
|
Maybe beyond the scope of the PR, but for my opinion the most important point missing in the current README is any information regarding hardware requirements (minimum memory in GB etc.). Based on my conversations with newcomers this (and not anything software related) is the biggest impediment when starting out with Fineract. |
You can use FINERACT-2326 for this ;) |
Good to know, thanks @steinwinde . Maybe a separate PR for that, though, unless you and @kengneruphine want to expand work in this PR? Your call |
superseded by latest changes, will start new review
|
@kengneruphine LGTM. Please squash this PR into a single commit and rebase on |
01b1133 to
190d636
Compare
Description
Update the Readme file by including the headers (tenantid and credentials) to facilitate new contributors in testing the application on Fineract.
FINERACT-2326
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.