FINERACT-2398: Re-amortization Interest Handling configuration - #5117
Conversation
f40850c to
b05ea7d
Compare
budaidev
left a comment
budaidev
left a comment
There was a problem hiding this comment.
Check the naming and reaging references before submit
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.fineract.portfolio.loanaccount.domain.reaging; |
There was a problem hiding this comment.
Any reason for LoanReAmortizationInterestHandlingType to be in the reaging package instead of the reamortization package?
| import org.springframework.data.jpa.repository.JpaRepository; | ||
| import org.springframework.data.repository.query.Param; | ||
|
|
||
| public interface LoanReAgingParameterRepository extends JpaRepository<LoanReAmortizationParameter, Long> { |
There was a problem hiding this comment.
Doing only LoanReAmortizationParameter related operation in the LoanReAgingParameterRepository seems confusing
There was a problem hiding this comment.
Done! I've updated the java package
There was a problem hiding this comment.
Please rename from LoanReAgingParameterRepository to LoanReAmortizationParameterRepository
|
|
||
| CodeValue reasonCodeValue = null; | ||
| if (command.parameterExists(LoanReAgingApiConstants.reasonCodeValueIdParamName)) { | ||
| reasonCodeValue = codeValueRepository.findByCodeNameAndId(LoanApiConstants.REAGE_REASONS, |
There was a problem hiding this comment.
I might be wrong, but isn't it LoanApiConstants.REAMORTIZATION_REASONS?
There was a problem hiding this comment.
Done! Code updated
| } | ||
|
|
||
| CodeValue reasonCodeValue = null; | ||
| if (command.parameterExists(LoanReAgingApiConstants.reasonCodeValueIdParamName)) { |
There was a problem hiding this comment.
Isn't it LoanReAmortizationApiConstants instead of LoanReAgingApiConstants?
There was a problem hiding this comment.
Done! Code updated
|
|
||
| private LoanReAmortizationValidator underTest = new LoanReAmortizationValidator(); | ||
| @InjectMocks | ||
| private LoanReAmortizationValidator underTest; |
There was a problem hiding this comment.
You changed here to InjectMocks instead of the creation, how we handle the CodeValueRepository which is injected inside the LoanReAmortizationValidator? Do we validate if it is correct?
There was a problem hiding this comment.
@budaidev I am not changing the Test by Itself, I mean currently there is not a validation to include the CodeValueRepository, I don't know If I need to include this
b05ea7d to
34fff4b
Compare
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Please kindly see my review!
453c507 to
2a5c1fd
Compare
2a5c1fd to
74c04db
Compare
3 participants
Description
User should be able to do re-amortization on Interest bearing loan accounts as well (progressive strategy only)
User should be able to select the following Interest handling subtypes from the drop down during application of re-amortization to the loan account
FINERACT-2398
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.