FINERACT-2354: Re-aging: DEFAULT BEHAVIOUR - Reverse Replay handling - #5146
Merged
Conversation
MarianaDmytrivBinariks
force-pushed
the
FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-reverse-replay-handling
branch
from
November 10, 2025 14:12
1789075 to
f9abd4d
Compare
mariiaKraievska
marked this pull request as ready for review
November 10, 2025 15:48
MarianaDmytrivBinariks
force-pushed
the
FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-reverse-replay-handling
branch
from
November 11, 2025 11:37
f9abd4d to
2323c39
Compare
adamsaghy
reviewed
Nov 12, 2025
| | Transaction date | Transaction Type | Amount | Principal | Interest | Fees | Penalties | Loan Balance | Reverted | Replayed | | ||
| | 01 January 2024 | Disbursement | 100.0 | 0.0 | 0.0 | 0.0 | 0.0 | 100.0 | false | false | | ||
| | 01 February 2024 | Repayment | 17.01 | 16.43 | 0.58 | 0.0 | 0.0 | 83.57 | false | false | | ||
| | 15 March 2024 | Re-age | 84.28 | 83.57 | 0.71 | 0.0 | 0.0 | 0.0 | false | true | |
Contributor
Author
There was a problem hiding this comment.
You're right, it shouldn't be. Fixed with recent develop changes
… additional test case
mariiaKraievska
force-pushed
the
FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-reverse-replay-handling
branch
from
November 13, 2025 08:34
2323c39 to
5f100d0
Compare
Contributor
Author
|
PTAL |
adamsaghy
deleted the
FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-reverse-replay-handling
branch
November 13, 2025 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added an additional test for the situation where we have reversal of backdated repayment.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.