FINERACT-2474: Add Unit Tests for ClientReadPlatformServiceImpl - #5466
Merged
adamsaghy merged 1 commit intoFeb 11, 2026
Merged
Conversation
Contributor
|
Please squash your commits. |
nidhiii128
force-pushed
the
FINERACT-TEST-client-read-service
branch
from
February 9, 2026 22:00
08010f6 to
4b937f2
Compare
Contributor
Author
@airajena done |
Contributor
|
@nidhiii128 please make sure that the PR title and the Jira ticket title are the same. |
Member
|
@nidhiii128 Check is failing due to space between FINERACT-2474 : |
Contributor
|
nidhiii128
force-pushed
the
FINERACT-TEST-client-read-service
branch
from
February 10, 2026 10:49
4b937f2 to
f0a0e39
Compare
Contributor
Author
@adamsaghy Done! I've run ./gradlew spotlessApply and amended the commit. It should be clean now. Thanks for the help with the title! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces unit tests for ClientReadPlatformServiceImpl to improve code coverage and ensure logic reliability within the fineract-provider module.
Technical Details
Created ClientReadPlatformServiceImplTest using JUnit 5 and Mockito.
Covered the retrieveOne success scenario with mock data.
Verified error handling for ClientNotFoundException when the database returns no results.
Added validation testing for retrieveAll to ensure invalid search statuses are rejected correctly.
Applied Spotless formatting to match project standards.
Testing
Successfully ran ./gradlew :fineract-provider:test --tests "org.apache.fineract.portfolio.client.service.ClientReadPlatformServiceImplTest"
Verified local build with ./gradlew spotlessJavaCheck.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.