Skip to content

bug(ui): composer-skill-picker tests crash — ComposerSkillPicker reads undefined label/panelAriaLabel #1941

Description

@Astro-Han

What happened
Three tests in packages/ui fail on latest main (76e1476, clean build) with a render-time crash:

TypeError: Cannot read properties of undefined (reading 'label')          at ComposerSkillPicker
TypeError: Cannot read properties of undefined (reading 'panelAriaLabel') at ComposerSkillPicker

Failing tests: renders a closed trigger with the selection count and no panel, localizes the trigger, hideTrigger mounts nothing when closed (quiet composer opens from +).

How to reproduce
cd packages/ui && node --test dist/__tests__/composer-skill-picker.test.js → 3 failures (2/5 pass).

Environment

  • Maka commit: 76e14764a
  • OS: macOS + Node v26.5.1
  • Surface: tests only

Additional context
Likely a regression from d1585040d refactor(ui): unify the composer's Skill surfaces on / and inline chips (#1915) — the component prop shape changed but these tests were not updated. The crash is also reachable in the renderer for any call site passing the old prop shape.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions