Prefer RuntimeEvent read model for session reads - #13
Merged
likun666661 merged 2 commits intoJun 15, 2026
Conversation
Member
Author
|
Follow-up risk cleanup is pushed in What changed:
Verification:
Final verdict: pass. |
jackwener
pushed a commit
that referenced
this pull request
Jun 21, 2026
…tover Prefer RuntimeEvent read model for session reads
jackwener
pushed a commit
that referenced
this pull request
Jun 21, 2026
…tover Prefer RuntimeEvent read model for session reads
jackwener
pushed a commit
that referenced
this pull request
Jun 21, 2026
…tover Prefer RuntimeEvent read model for session reads
jackwener
pushed a commit
that referenced
this pull request
Jun 21, 2026
…tover Prefer RuntimeEvent read model for session reads
anaconda110
added a commit
to anaconda110/maka-agent
that referenced
this pull request
Aug 3, 2026
All current dependencies (React Native, keychain, sqlite, AppCompat, Hermes) are hosted on google() and mavenCentral(); no dependency pulls from JitPack. The extra repository only slows resolution and adds a supply-chain surface, so drop it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionManager.getMessages()andlistTurns()prefer RuntimeEvent-projected session views when durable per-run runtime ledgers are usable.StoredMessage[]andTurnRecord[].Rive
wfrun_65d83dede37f4a8bb7af4375ab5fbb89sched_715dace105ce4c7399692dafcfa46ff4pass_with_risksFallback policy
RuntimeEvent reads fall back to legacy
SessionStorefor no runStore, no runs, active/non-terminal runs, missing/empty runtime ledgers, missing terminal RuntimeEvents, hard projection diagnostics, run-store read failures, or hard compatibility gaps.MAKA_RUNTIME_READ_SOURCE=legacyforces legacy reads as an emergency rollback.Known risks
AgentRunStore.readRuntimeEvents()still skips corrupt RuntimeEvent JSONL lines silently, so semantic compatibility remains the current safety boundary until storage exposes corruption diagnostics.Verification
npm run build --workspace packages/corenpm run typecheck --workspace packages/runtimenpm run test --workspace packages/runtime -- --runInBand(427 tests, 0 failures)git diff --checknpm run test --workspaces --if-presentsuccessfully, including desktop 1399 tests / 0 failures.