PR-SETTINGS-REVIEW-0: rapid-iteration Settings polish (8 fixes) - #139
Merged
Conversation
…e bundle
WAWQAQ msgs `2b27c5d2`, `f97ed407`, `8577326c`, `1b2d4e83`, `886f6406`,
`6759cd0f`, `e1194266` — a back-and-forth review pass that surfaced
~8 issues. Bundled into one PR (per project preference for larger PRs)
rather than 8 micro-PRs.
Changes:
1. **Sidebar title + traffic light spacing** (`1b2d4e83`): the 22px
sidebar top padding put the 设置 brand right against the macOS
traffic light row. Bumped to 52px so the brand sits with clear
breathing room below the OS chrome. Same fix on `.settingsMainPane`
top padding.
2. **Row borders too hard** (`f97ed407`): `var(--border)` competed
with the surrounding pane chrome. Switched to a 6%–8% foreground
tint so the card edge is suggestive, not declarative. Background
stays transparent; hover amplifies border to 14% and adds a 2% bg.
3. **Page title misaligned with content** (`8577326c`): page header
was in the mainpane padding (~34px from edge), rows lived in the
centered max-w-3xl column (~158px from edge at 1280 viewport).
Now both align via matched edge math:
`padding: 0 max(24px, calc((100% - 768px) / 2 + 24px))`. Page
title now sits directly above the first row card.
4. **`返回应用` replaces right-side X close** (`e1194266`): the X
button was visually orphaned and didn't match reference's
"back to app" affordance. Replaced with a left-aligned chevron
`← 返回应用` link at the top of the sidebar.
5. **记忆 + 每日回顾 split back apart** (`886f6406`): the merged
memory-review page was too dense. 记忆 and 每日回顾 are separate
nav items again. Type, ALLOWED_SETTINGS_SECTIONS, render switch,
visual-smoke scenarios, deeplinks, tests all updated together.
6. **外观: 个性化 before 主题** (`6759cd0f`): identity ("who am I")
should come before presentation ("how does it look") top→down.
7. **Section heading L margin fix**: previously 4px L margin pushed
the heading off the card edge. Now flush at 2px so 主题 / 个性化
align visually with the first card row.
8. **Row hover state polish**: pure border-tone hover felt flat; add
a 2% bg lift so the hover signal is felt without flashy color.
1466 / 1466 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WAWQAQ ran a rapid review pass and flagged ~8 issues across a series of messages. Bundled into one PR per project preference for larger PRs.
Test plan