PR-SETTINGS-ROW-SPACIOUS-0: bigger row padding + typography (round 1/15) - #143
Merged
Conversation
WAWQAQ msg f7e9d166 + reference screenshots: settings rows are visibly more spacious in reference than in maka. WAWQAQ's QoderWork preferences screenshot showed rows ~80–90px tall with comfortable internal padding; maka's were 56px min-height with tight 16/20 padding, which read as cramped. Bumped `.settingsFormRow`: - min-height 56 → 72 - padding 16/20 → 20/24 - gap inside row 16 → 20 - label font-size 14 → 15px, line-height 1.35 - hint font-size 12 → 13px, color tone -50 → -55, line-height 1.45 - hint margin-top 4 → 6px Row hover and divider behaviour unchanged from PR-GROUPED-CARD-0. 1466 / 1466 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Round 1/15 of the structured polish loop (WAWQAQ msg `f7e9d166`). Reference settings rows are visibly more spacious than maka's — ~80-90px tall with comfortable internal padding, while maka was at `min-height: 56px` with tight 16/20 padding.
`.settingsFormRow`:
Hover + divider behaviour unchanged.
Test plan