PR-SETTINGS-SWITCH-SCALE-0: bigger switches inside settings rows (round 3/15) - #145
Merged
Conversation
…nd 3/15) Shared Switch primitive renders at h-5 w-9 (20×36) — fine for chat / sidebar toggles but cramped inside the now-roomy settings rows. Reference's settings toggles are noticeably larger. Scoped the bump to settings rows only so the Switch primitive stays compact elsewhere: - track 20×36 → 26×46, radius 999 - thumb 16 → 22 - checked-state translate updated from `1.125rem` to `22px` so the thumb actually reaches the right edge at the new track width - scoped via `.settingsFormRow [role="switch"]` / `.settingsField [role="switch"]` 1466 / 1466 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 3/15. Switch primitive at 20×36 was too small inside the now-roomy settings rows. Scoped the bump to settings only — 26×46 track, 22×22 thumb, checked-state translate updated to 22px so the thumb reaches the edge. Chat / sidebar switches unaffected.