fix(desktop): add OAuth account channels to Models story bridge - #1548
Merged
Astro-Han merged 1 commit intoJul 28, 2026
Merged
Conversation
Contributor
|
Reviewed at No P0-P2 findings. P3: The Story fixtures do not satisfy the full preload return types. All four account states omit Squash-merged as |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Models settings page story rendered against a bridge with no subscription channels, so ModelOAuthSection's experimental-gate call rejected on mount: the Claude card never appeared and the other three stayed frozen at their static 可用 label, a screen the app never shows. I added claudeSubscription (including isExperimentalEnabled), openAiCodex, githubCopilotSubscription and xaiOAuth to that story bridge, plus a contract assertion that derives the required channel list from provider-oauth-section.tsx so a newly added channel fails loudly instead of quietly degrading the story. The remaining visual audit in the issue is left for after #1421 lands, since it rewrites the same form and fixtures. Fixes #1367.
I pushed this to my fork first and the project's own CI workflows pass on the commit.