fix(desktop): keep hit-test fixtures out of foreground - #1667
Merged
Conversation
Astro-Han
force-pushed
the
fix/1565-background-hit-test
branch
from
July 30, 2026 17:26
d6bd266 to
799e4f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #1565.
The Astryx hit-test contract needs a compositor-mapped Electron window for
elementFromPoint, but it does not need foreground focus. The harness previously setMAKA_E2E_SHOW_WINDOW=1, which routed startup throughBrowserWindow.show()and interrupted the developer once per fixture route.mapWindowInactiveoption instead of parallel hidden/inactive/visible mode stateBrowserWindowthroughshowInactive(), then fail closed unless it is visible and unfocusedshowInactive()on native WaylandVerification
npm run build— passednpm run test:scripts— 224 passednpm run lint— passednpm run format:check— passednpm run typecheck— passednpm run check:hit-test— 5/5 routes clean; frontmost-app sampling remained on Ghostty throughout the final runnpm run check:visual-contract— 20/20 comparisons clean againstmain; frontmost-app sampling remained on Chrome throughoutReview focus
withFixtureWindowowns the mapping policy: captures stay hidden by default, hit testing requests inactive mapping, and only isolated Linux CI displays use the existing visible startup path. On a Wayland session, the inactive launch adds--ozone-platform=x11; all other launch modes retain Electron's platform default.