refactor(ui): migrate Markdown core to Astryx - #1668
Merged
Conversation
Astro-Han
changed the base branch from
refactor/1565-markdown-contract-hook
to
main
July 30, 2026 17:18
Astro-Han
force-pushed
the
refactor/1565-pr7-markdown-core
branch
from
July 30, 2026 17:18
476b850 to
010c765
Compare
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #1565.
maka:navigation allowlist separate from thehttp/httpsimage policy, and prevent non-allowlisted Markdown images from loading.Verification
npm --workspace @maka/ui test— 280 passed.npm --workspace @maka/desktop test— 2966 passed.npx playwright test --config e2e/playwright.config.ts e2e/send-message.spec.ts— 2 passed, including exact copied code and clipboard rejection feedback.npm run rebuild,npm run typecheck,npm run lint,npm run format:check, andnpm run check:release— passed.npx knip --workspace packages/uiandnpx knip --workspace apps/desktop— passed (desktop reports only the existingelectron-builderconfiguration hints).npm --workspace @maka/desktop run build-storybook— passed.npm run check:visual-contract -- --against main --scopes scripts/visual-contract-scopes/pr7-markdown-core.json— 20/20 route, theme, and platform comparisons clean; 48 Markdown/turn-flow changes declared where the chat fixture is present and zero changes outside the declared subtree.npm run check:hit-test— 5/5 routes clean.Review focus
components.imagefor standalone image blocks. The pre-parse guard closes that upstream gap while leaving fenced and inline code untouched; tests cover direct, inline, and reference images.scripts/visual-contract-scopes/pr7-markdown-core.jsonis the issue-required declaration for this migration slice; the final migration cleanup PR removes the harness.package-lock.jsonandapps/desktop/resources/licenses/npm/THIRD_PARTY_NOTICES.txtare generated reductions from removing Streamdown's production dependency closure.Visual evidence
Live Electron shell, light theme (deterministic E2E fixture):