refactor(ui): move modal layers to Astryx - #1674
Merged
Merged
Conversation
Astro-Han
force-pushed
the
refactor/1565-floating-controls
branch
from
July 31, 2026 03:08
0871f48 to
9b4b53e
Compare
Astro-Han
force-pushed
the
refactor/1565-modal-layers
branch
from
July 31, 2026 03:08
e5b8f4a to
153c848
Compare
Astro-Han
force-pushed
the
refactor/1565-floating-controls
branch
from
July 31, 2026 03:54
9b4b53e to
8a3d8ab
Compare
Astro-Han
force-pushed
the
refactor/1565-modal-layers
branch
2 times, most recently
from
July 31, 2026 04:03
96c38f3 to
2505698
Compare
Astro-Han
force-pushed
the
refactor/1565-modal-layers
branch
from
July 31, 2026 04:04
2505698 to
6597253
Compare
Astro-Han
marked this pull request as ready for review
July 31, 2026 04:24
This was referenced Jul 31, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #1565.
Moves Dialog, AlertDialog, Toast, and the root notification layer to Astryx while preserving Maka's product APIs and conditional-rendering semantics.
falsesuppresses restoration, otherwise focus returns to the opener.Verification
npm run format:check && npm run lint && npm run typechecknpm run buildnpx playwright test --config e2e/playwright.config.ts— 87 passednode scripts/check-visual-contract.mjs --against origin/main --scopes scripts/visual-contract-scopes/pr6-modal-layers.json— 20 comparisons cleanRoot cause
The migration initially confused three different responsibilities. Astryx owns modal mechanics and visuals, but the Maka adapter still owns compatibility semantics used by application consumers. The deterministic E2E harness also paused Astryx's backwards-filled entry animation at time zero, which froze fixture dialogs in their hidden frame. Finally, two geometry tests sampled intentional 400 ms entry transforms instead of the settled layout.
The fix keeps those responsibilities at their natural owners: the adapter supplies only roles, stable hooks, and conditional-unmount focus information; the fixture removes decorative animation instead of freezing its first frame; geometry tests wait for the dialog's own animation to settle without weakening any dimensions.
Review focus