refactor(ui): reclassify form consumers around Astryx - #1678
Merged
Conversation
Astro-Han
force-pushed
the
refactor/1565-form-controls-astryx
branch
5 times, most recently
from
July 31, 2026 13:33
a6bcaae to
2fcf652
Compare
Astro-Han
force-pushed
the
refactor/1565-form-controls-astryx
branch
from
July 31, 2026 13:48
2fcf652 to
8ed44e8
Compare
Astro-Han
marked this pull request as ready for review
July 31, 2026 13:55
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Field,TextInput,TextArea,NumberInput,InputGroup,CheckboxInput,RadioList,SelectableCard, andSwitch; redesign theme selection, custom question answers, password fields, and MCP editing around those semantics.Refs #1565
Verification
npm test --workspace @maka/ui— 282 passednpm test --workspace @maka/desktop— 2961 passednpm run e2e --workspace @maka/desktop -- --workers=1— 87 passednpm run lintnpm run format:checknpm run typechecknpm run check:visual-contract -- --against main --scopes scripts/visual-contract-scopes/pr4-form-controls.json— 20 comparisons cleannpm run check:hit-test— 5 routes cleannpm run build-storybook --workspace @maka/desktopnpm run smoke:storybook --workspace @maka/desktop— 26 render/play checks passedReview focus
The published Astryx API is the fixed boundary. This PR deliberately changes old DOM, focus choreography, and visual treatments when they do not map cleanly to Astryx, while preserving product outcomes and accessibility.
The composer textarea, autocomplete inputs, and inline rename inputs remain native because their owning product/library seams require direct element control. They are product-specific controls, not a parallel generic form system.