fix(cli): align readiness fixtures with enabled-model gate - #1693
Merged
Conversation
#1691 made isConnectionReady require the effective model in connectionEnabledModelIds; two CLI fixtures still requested models that were only present in the discovered catalog, which broke main CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main CI has been red since #1691:
isConnectionReadynow requires the effective model to be inconnectionEnabledModelIds(user-enabled set), not merely present in the discoveredmodelscatalog. Two CLI fixtures still requested models that were only in the catalog, so they failed withNO_REAL_CONNECTION:model_not_enabled.This updates those fixtures to match the product contract. No production code change.
Refs #1691
Verification
npm --workspace maka-agent run buildnpm --workspace maka-agent run test:dist— 689 pass / 0 fail (covers both previously failing cases)Did not re-run full monorepo CI or e2e locally; those remain on the PR check suite.