fix: align settings and modules with Astryx authority - #1747
Merged
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1733. Removes the remaining Maka-owned presentation paths that duplicate Astryx 0.1.9 behavior.
Verification
Review focus
The implementation was compared against the official Astryx 0.1.9 Storybook and package source. Astryx now owns component geometry, responsive layout, disclosure, loading, feedback, tabs, menu dismissal, dialog trapping, and focus restoration; Maka retains product data, runtime, IPC, persistence, routing, validation, security state, and the identity of the product action opening a dialog.
At the current base commit 82f7dfc, the full E2E job still fails on eight out-of-scope conversation journeys: disclosure output, two permission-mode cases, four scroll-geometry cases, and session-health notice. This PR does not modify those authorities. Its Settings navigation regressions and Plan Reminder focus race are covered by the passing targeted suite above.