Skip to content

fix: align settings and modules with Astryx authority - #1747

Merged
Astro-Han merged 11 commits into
mainfrom
fix/settings-modules-astryx-authority
Aug 1, 2026
Merged

fix: align settings and modules with Astryx authority#1747
Astro-Han merged 11 commits into
mainfrom
fix/settings-modules-astryx-authority

Conversation

@Astro-Han

@Astro-Han Astro-Han commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #1733. Removes the remaining Maka-owned presentation paths that duplicate Astryx 0.1.9 behavior.

  • use Astryx Layout, LayoutPanel, LayoutHeader, LayoutContent, and useMediaQuery for the settings shell
  • use TabList for module navigation and Collapsible for Daily Review archives
  • use Banner and Skeleton for provider failures and loading states
  • remove plan-tab geometry overrides and reserve skill badges for exceptional state only
  • let Astryx DropdownMenu and Dialog own Plan Reminder close/Escape/focus behavior without Maka frame-timing restoration
  • update authority contracts and Electron journeys to the resulting Astryx navigation semantics

Verification

  • npm run format:check
  • npm run lint
  • npm run build
  • npm run typecheck
  • npm --workspace @maka/desktop test — 1855 passed
  • npm --workspace @maka/ui run test:dist — 294 passed
  • npm --workspace @maka/desktop run build-storybook
  • npm --workspace @maka/desktop run smoke:storybook — 51 render/play checks passed
  • targeted Settings/Modules Electron suite — 30 passed
  • Plan Reminder menu-to-dialog focus stress — 20/20 passed with four workers
  • GitHub CI typecheck and test — passed
  • GitHub CI e2e — 85 passed; the remaining 8 failures match the current base conversation regressions listed below

Review focus

The implementation was compared against the official Astryx 0.1.9 Storybook and package source. Astryx now owns component geometry, responsive layout, disclosure, loading, feedback, tabs, menu dismissal, dialog trapping, and focus restoration; Maka retains product data, runtime, IPC, persistence, routing, validation, security state, and the identity of the product action opening a dialog.

At the current base commit 82f7dfc, the full E2E job still fails on eight out-of-scope conversation journeys: disclosure output, two permission-mode cases, four scroll-geometry cases, and session-health notice. This PR does not modify those authorities. Its Settings navigation regressions and Plan Reminder focus race are covered by the passing targeted suite above.

@Astro-Han
Astro-Han merged commit cbb96f6 into main Aug 1, 2026
2 of 3 checks passed
@Astro-Han
Astro-Han deleted the fix/settings-modules-astryx-authority branch August 1, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant