fix(desktop): keep latest onboarding snapshot handoff - #1924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The desktop bootstrap latched the first mounted onboarding snapshot until AppShell consumed it. If a session was created and a newer snapshot arrived before React committed, AppShell still seeded the older empty session list. The conversation rendered, but the sidebar never showed the unassigned-project entry.
Keep the latest mounted snapshot as the one-time bootstrap handoff and add a regression test for a session created between two pre-commit snapshot reductions. This fixes the flaky
project-management.spec.tsfailure without adding retries or changing the E2E timeout.Closes #1923
Verification
npm --workspace @maka/desktop run test -- src/main/__tests__/use-onboarding-snapshot.test.ts: 10 passednpm --workspace @maka/desktop run build:main: passedproject-management.spec.ts, 50 serial repeats: 50 passednpm --workspace @maka/desktop run test:e2e: 89 passednpm run lint: passednpm run format:check: passednpm --workspace @maka/desktop run typecheck: passednpm --workspace @maka/desktop test: 1364 passedgit diff --check: passed