fix(ui): preserve sent inline references with Astryx - #1927
Merged
Conversation
Astro-Han
force-pushed
the
refactor/1861-sent-reference-hierarchy
branch
from
August 3, 2026 05:07
f329b56 to
1af3849
Compare
Astro-Han
marked this pull request as ready for review
August 3, 2026 05:56
Astro-Han
force-pushed
the
refactor/1861-sent-reference-hierarchy
branch
from
August 3, 2026 05:57
1af3849 to
664704a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@filereferences come from surviving Composer tokens, while successful explicit Skill invocations come from runtime receipts.ChatMessagechildren before the authored-text bubble.inlineReferences: []end to end as the current-format marker. Only legacy messages with the field absent use text-token fallback.Closes #1861
Verification
npm run format:check,npm run lint, andnpm run typecheck— passed after rebasing onto currentmain.npm --workspace @maka/core test— 695/695 passed.npm --workspace @maka/runtime test— 2700 passed, 9 skipped.npm --workspace @maka/ui test— 240/240 passed.npm --workspace @maka/storage test -- session-store— 1024 passed, 1 skipped.npm --workspace @maka/desktop test— 1375/1375 passed.npm --workspace @maka/desktop run e2e -- composer-mention-token.spec.ts— 4/4 passed after rebase, including real token selection, identical plain-text occurrence, send, and reload persistence.npm --workspace @maka/desktop run build-storybook— passed after rebase.Visual evidence
Live Storybook state:
Product/Attachments/Sent Reference Hierarchy.The inspected state covers unclipped attachment icons, the native Astryx image thumbnail, the quote row, and
/skill:writerplus@chat-turn.tsxusing the same token projection as Composer.Review focus
startis a UTF-16 offset intodisplayText ?? text. It is necessary to distinguish a selected token from an identical plain-text occurrence and is validated at Core and IPC boundaries.