fix(runtime): close lifecycle races exposed by CI - #1934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English
Summary
Why
The full workspace CI run after #1928 exposed two independent existing timing assumptions under parallel load. A high-load reproduction also exposed a shutdown ordering bug that could leave the Host test process alive after its socket path had already been removed.
These changes make the lifecycle boundaries causal instead of relying on child-output timing, fixed sleeps, or a fast filesystem.
Verification
main简体中文
概要
原因
#1928 合并后的完整 workspace CI 在并行负载下暴露了两个彼此独立的既有时序假设。高负载复现还发现了一处 shutdown 顺序问题:socket 路径已经移除后,Host 测试进程仍可能因 listener 未关闭而存活。
这些修改让生命周期边界由明确事件决定,不再依赖子进程输出时机、固定 sleep 或快速文件系统。
验证
main上通过带 Storage stress 的完整 affected-workspace CI 测试矩阵