fix(desktop): deep-review round over the settings convergence + shell seam - #1997
Merged
Conversation
… seam Adversarial review of #1984/#1991/#1993 (two independent lenses, findings verified before fixing) plus one user-reported shell defect. Shell: - The content column is a rounded floating plate flush to the sidebar; the theme's full-height sidenav hairline ran on the same seam and read as a doubled border beside the plate's corner radius. Dropped in the expanded state too (collapsed already did) — separation is tonal, per DESIGN.md's One Working Plane rule. Regressions from #1993, confirmed and fixed: - bot-chat-detail lost all inter-section rhythm: its wrapper pair kept a gap on a display:block section (inert) and a class with no CSS rule. The page is a SettingsPage now, like the overview next door; the back button keeps only its optical inline outdent. - bot.css had the file-header comment replace-all'd into the middle of `.settingsBotDetailHeader > .settingsBotLogo`. Parsed by luck; removed. - MetadataList destructures a closed prop list, so the runtime grid's aria-label was silently dropped — the group name rides a real role="group" wrapper now. - The kit section header now wraps: at the 480px window floor a multi-button action cluster drops under the title instead of crushing it (replaces the deleted bot-runtime media query). - Overview rows go flush-inline (the 10px inset was old card-grid residue); the WeChat QR dialog gets its height floor back (224px) so state swaps stop resizing the modal. Convergence completions the review surfaced: - claude-subscription-card drops its SectionHeader + full-width Card and repeated title: it renders under ProvidersPanel's RouteHeader like its sibling OAuth panels, as a bare VStack with the shared StatusDot + text status idiom. - ProvidersPanel connection status Badge -> StatusDot + text; health's hand-rolled five-arm dot mapping -> the shared statusDotVariant. - subagent-presets panel: Card-wrapped .settingsRows + a lead Item posing as a header -> SettingsSection; settings-surface fallback drops its Card wrap. - About hero pills referenced two classNames with no CSS rule — they are the Badges about.css's comment always described. - `.settingsPage .settingsPageStack` (rename slip) -> nested `.settingsPageStack .settingsPageStack`; quota labels round. Verified: typecheck, check-dead-css, check-a11y/copy/console, format:check, product Storybook smoke (71 renders x 3 viewports).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deep adversarial review of #1984 / #1991 / #1993 (two independent review lenses; every finding verified against the tree before fixing), plus the user-reported doubled-border shell defect.
Shell seam (user report)
The content column is a rounded floating plate flush to the sidebar — its edge is the one boundary on that seam. The theme's full-height sidenav hairline (
.astryx-app-shell-sidenav.elevatedin the built maka.css) ran on the same seam, reading as a doubled border beside the plate's top-left corner radius. The collapsed rail already dropped this edge; it's dropped expanded too. Override lives in product CSS (maka.css is a generated artifact).Confirmed regressions from #1993, fixed
gapon adisplay:blocksection (inert) and a class with no CSS rule at all. Now aSettingsPagelike the overview next door..settingsBotDetailHeader > .settingsBotLogo. Parsed by luck; removed.aria-label(closed prop destructuring, no...rest): the runtime grid's group name now rides a realrole="group"wrapper..settingsPage .settingsPageStackrename slip →.settingsPageStack .settingsPageStack; quotaformatValueLabelrounds.Convergence completions the review surfaced
SectionHeader+ full-widthCard+ repeated title — it renders under ProvidersPanel's RouteHeader exactly like its sibling OAuth panels (bareVStack), with the shared StatusDot + text status idiom. Removes the last oldSectionHeaderin settings.statusDotVariant..settingsRows+ a leadItemposing as a header →SettingsSection; the settings-surface fallback drops its Card wrap.Badges about.css's comment always described.Known items deliberately deferred (copy/product decisions)
usage page kit conversion (L), bot-detail header dialect (guarded by the e2e focus-order contract), voice
statusAriareused as a visible title, memory quiet-warning boxes vs Banner (depends on the #1972 "un-blue" direction), icon-plate unification.Verification
typecheck ✅ · check-dead-css ✅ · check-a11y/copy/console ✅ · format:check ✅ · product Storybook smoke 71 renders × 3 viewports ✅