redesign(ui): plan-reminder list rows meet the Astryx premium checklist - #2011
Merged
Conversation
First execution wave of the premium-quality goal (WAWQAQ /goal f2a64902), applying the checklist distilled from Astryx's own page templates (incident-console is the model for this surface): - Rows: the hand-rolled 3-column `.maka-plan-card` grid (~68px) becomes a single flex row — leading switch (ghost slot keeps completed rows aligned), title + exception-only StatusDot clusters, ONE supporting schedule line, a right-aligned localized countdown, trailing menu. Edge-to-edge with list-owned hairlines. - Badge misuse eliminated (the checklist's most explicit DON'T): the per-row countdown pill and run-status Badge are gone. Durations are quiet supporting text (the locale-aware formatter — Astryx Timestamp renders Intl relative time in English only, a zh-locale bug we avoided); run state appears once as StatusDot + text, and run MESSAGES live in the 执行记录 tab, not in every task row. - Rhythm: the flat 8px shell gap becomes the two-tier rhythm (24px between page tiers, small steps inside units). - Filters move into an Astryx Toolbar (size set once) instead of three pinned-width divs; the first-run EmptyState gains its create CTA and the runs empty state drops its dashed decoration. - Runs tab rows join the same row idiom (StatusDot + text, no card chrome). Contracts updated to pin the NEW design: the two unit tests that asserted the old markup, the e2e fixture readiness selector, and the storybook smoke's product checks (flex-row layout + countdown right-alignment replace the 3-column-grid assertions). Verified: build, typecheck, check-dead-css, check-a11y/copy/console, unit 9/9, plan-reminders e2e 2/2 locally, Storybook smoke (74 renders x 3 viewports), rendered screenshot reviewed against the reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First execution wave of the premium-quality goal. Method: distilled an 18-rule "premium checklist" from Astryx's own CLI page templates + component design docs (
incident-consoleis the model template for this surface), then rebuilt the 定时任务 list against it.What changed
.maka-plan-cardgrid (~68px tall) → a single flex row: leading switch (ghost slot keeps completed rows aligned), title + exception-only StatusDot clusters, one supporting schedule line, right-aligned localized countdown, trailing menu. Edge-to-edge, list-owned hairline dividers.Timestamp, which outputs Intl relative time in English inside a zh UI); run state appears once as StatusDot + text; run messages live in the 执行记录 tab, not in every task row.Toolbar(size set once) instead of three pinned-width divs.Contracts updated to pin the new design
Two unit tests that asserted the old markup, the e2e fixture readiness selector, and the storybook smoke product checks (flex-row + countdown right-alignment replace the 3-column-grid assertions).
Verification
build ✅ typecheck ✅ dead-css ✅ a11y/copy/console ✅ unit 9/9 ✅ plan-reminders e2e 2/2 locally ✅ Storybook smoke 74 renders × 3 viewports ✅ — rendered screenshot in the work thread.
Next waves: extensions/skills page (its own checklist deltas: hover-lift shadows, heading-as-caption ×9, hand-rolled list), then the settings polish round (Layout frames, two-column settings grid, ExpandableRow).