polish(ui): skill empty states gain their next-step actions - #2019
Merged
Conversation
Premium checklist rule 18 (every empty region gets a specific description AND a next-step action), applied selectively per the design-review direction — no layout changes: - Marketplace search-empty gains 清空搜索; filtered-to-zero gains 清空筛选 (resets category + search together); the built-in catalog's no-match state gains 清空搜索. - The header search box is owned by the outer panel, so the library panel gains an optional onClearSearch callback; the installed list keeps its existing refresh action. - Skeleton first-paint was considered and dropped honestly: these panels have no async loading seam — inventing one for a placeholder would be fake motion. Self-reviewed; build/typecheck/format/dead-css/checks/smoke all green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selective-adoption follow-up (no layout changes): checklist rule 18 says every empty region needs a specific description and a next-step action. Marketplace search-empty → 清空搜索; filtered-to-zero → 清空筛选 (resets category + search); built-in no-match → 清空搜索. The library panel gains an optional
onClearSearch(the search box lives in the outer header). Skeleton first-paint was considered and dropped honestly — these panels have no async seam, and a fake loading phase would be fake motion. Self-reviewed; full local verification green.