perf(desktop): lazy-mount sidebar session trees - #2021
Merged
jackwener merged 3 commits intoAug 4, 2026
Conversation
likun666661
marked this pull request as ready for review
August 3, 2026 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The sidebar recursively rendered every linked child session even when its parent appeared collapsed. On a real workspace with 36 root sessions and 118 Swarm child sessions, the expanded rail kept roughly 10,000-12,000 DOM nodes and thousands of listeners alive. Any navigation or selection then paid React, style, and layout costs across that tree.
Local CDP evidence
The 118 child rows are now absent from the DOM until their parent is expanded. Eighteen roots retain disclosure controls.
Validation