fix(release): regenerate third-party notices for the upgraded production tree - #2056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#2055 upgraded four production dependencies to clear the release audit, but did not regenerate the bundled license inventory.
Release macOS arm64run 30849279454 then failed insidenpm run package:macos-arm64:This is the output of
npm run generate:third-party-notices. Four version lines change, one per upgraded package:@hono/node-server@modelcontextprotocol/sdkfast-uriundiciNo package is added or removed and no declared license changes (MIT and BSD-3-Clause throughout). The
@hono/node-serverentry also normalizes its repository URL to thegit+https://form the package now publishes.Verification
npm run check:release— the exact command the release packaging step runs, and the one that caught this. All three gates pass:check:stalereports dist fresh,check:third-party-noticesreports the inventory current,check-dead-cssfinds nothing dead.npm cithennpm run build: clean.npm run format:check: clean.Review focus
check:releaseonly runs insidenpm run package:macos-arm64, so no ordinary CI lane exercises it — #2055 was fully green and still left this stale. Any future change to the production dependency tree needsnpm run generate:third-party-noticesin the same commit, or the release fails at packaging.Rollout
Re-dispatch
Release macOS arm64once this is onmainand CI is green. The failed run stopped beforeCreate draft GitHub Release, so nov0.1.4tag or release exists yet and the version does not need another bump.