fix(test): eliminate Desktop smoke false failures - #2101
Merged
jackwener merged 1 commit intoAug 4, 2026
Conversation
This was referenced Aug 4, 2026
xuruiray
force-pushed
the
xurui/fix-desktop-smoke-false-failures
branch
from
August 4, 2026 07:06
11c6c36 to
87ad434
Compare
xuruiray
force-pushed
the
xurui/fix-desktop-smoke-false-failures
branch
from
August 4, 2026 07:16
87ad434 to
10c1c18
Compare
xuruiray
marked this pull request as ready for review
August 4, 2026 07:26
Member
|
Review by maka-审美专家 — 通过:诊断选择器从被删的 .maka-search-modal 根类迁到稳定契约 data-maka-contract="search-modal"(已核 search-modal.tsx:210 存在);favicon 204 收窄到「文件确实缺失」路径且路径穿越检查保留;新增 HTTP 层回归测试覆盖 200/204/404 三态;旧字段名 searchModalBackdropPresent 全仓无残留。CI 11/11 绿。合入。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-maka-contract="search-modal"contract instead of the removed.maka-search-modalclass204only when the optional/favicon.icois absent, while preserving real favicon files and404responses for every other missing assetCloses #2096
Scope
Test infrastructure only. This PR does not change Desktop product UI, Runtime, IPC, MCP data, credentials, or connection lifecycle.
Current head
10c1c1866is rebased ontomain@121bbe73d. The branch contains one functional commit.Verification
npm run format:check— 1,463 filesnpm run lint— 2,373 filesnpm run buildnpm run typechecknpm run test:scripts— 105/105node --test scripts/storybook-visual-smoke.test.mjs— 1/1npm --workspace @maka/desktop test— 1,586/1,586npm --workspace @maka/desktop run smoke:programmatic-window— 7/7 on the exact current headnpm --workspace @maka/desktop run build-storybookGitHub CI on the exact current head is green: all 11 checks passed, including workspace tests, Runtime Host, Headless, Storybook, both E2E shards, aggregate E2E, typecheck, and alignment audit.
Regression behavior
The real Electron probe now confirms that the search modal is present, open, and owns focus through its stable contract. The Storybook server test confirms that only an absent optional favicon receives
204; an existing favicon is served normally and every other missing asset remains404.An earlier CI run exposed an unrelated Runtime concurrency flake in an unmodified filesystem-authority test. That exact test passed 11/11 in isolation, and the complete second CI run passed without any Runtime changes in this PR.