fix(desktop): give selection quote actions an opaque popover surface - #2154
Merged
Astro-Han merged 1 commit intoAug 4, 2026
Merged
Conversation
The floating 引用 / 在侧栏追问 selection popup rendered with no background of its own: the wrapper only set display, ButtonGroup elevation only adds a shadow, and the secondary buttons' --color-neutral fill is 6%-alpha black — so transcript text bled straight through the controls. Give .maka-quote-actions the opaque --color-background-popover surface and element radius, matching the ChatLayoutScrollButton convention for controls floating over scrollable content. Also drop the unused jumpLatest copy key from conversation-copy.ts. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16
Contributor
|
Nice Fix! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Problem
The floating 引用 / 在侧栏追问 popup that appears after selecting response text is effectively transparent — transcript text bleeds straight through the buttons, making them hard to read:
.maka-quote-actions(the layer wrapper) sets onlydisplay: inline-flex, no background.ButtonGroup elevation="med"only adds a box-shadow, by design.--color-neutral, which islight-dark(#0000000F, #FFFFFF1A)— a 6%-alpha translucent tone meant to sit on an opaque app surface, not to float over text.Fix
Give
.maka-quote-actionsthe opaque--color-background-popoversurface plus the element radius, so the translucent button fills and the group shadow land on a real surface. This mirrors the existing convention for controls floating over scrollable content (ChatLayoutScrollButtonputs the same popover surface behind its ghost button).Also removes the
jumpLatestcopy key fromconversation-copy.ts— it had no consumers in either locale (dead copy found while auditing other floating surfaces).Validation
npm --workspace @maka/ui run typecheckpassesdist/__tests__/conversation-localization.test.js— 17/17 passCo-Authored-By: Claude noreply@anthropic.com
https://claude.ai/code/session_01Ac5rv6WUKWtMZgQb5QPN16