Skip to content

test(windows): establish support baseline - #2156

Merged
jackwener merged 4 commits into
apache:mainfrom
liugddx:feat/windows-phase-0-baseline
Aug 4, 2026
Merged

test(windows): establish support baseline#2156
jackwener merged 4 commits into
apache:mainfrom
liugddx:feat/windows-phase-0-baseline

Conversation

@liugddx

@liugddx liugddx commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary

  • document the native Windows 11 x64 development baseline and current support boundary
  • inventory and classify all 65 test declarations currently excluded on Windows
  • add repeatable CLI and real Electron startup smoke coverage
  • fix Windows path, permission, Git long-path, and Electron process-tree issues found while establishing the baseline

Part of #2142.

Baseline results

  • workspace build: pass
  • repository script tests: 110 pass, 0 fail, 1 macOS-only skip
  • managed workspace baseline: 17 pass, 0 fail, 5 skip
  • Windows CLI and Electron startup smoke: pass, with no residual Electron processes
  • storage suite: 514 pass, 100 fail, 40 skip; failures are dominated by SQLite cleanup EBUSY
  • complete npm test: does not exit within 10 minutes and leaves the workspace runner alive

The failing storage and root-runner results are recorded diagnostic baselines for the next phase, not claims of full Windows support.

Validation

  • npm run windows:inventory
  • npm run test:scripts
  • node scripts/windows-smoke.mjs
  • Biome checks for all changed source files
  • git diff --check

@liugddx
liugddx force-pushed the feat/windows-phase-0-baseline branch from 465b334 to b60ce7c Compare August 4, 2026 13:58

@liugddx liugddx left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at 7c9271b7.

The earlier blocking inventory gap is resolved:

  • findSkipExpressions() now scans across line boundaries instead of requiring skip: and process.platform on the same source line.
  • regression coverage includes both a multiline ternary and a multiline logical expression;
  • the seven previously omitted declarations are now present in the generated inventory;
  • the documented total is corrected from 59 to 66;
  • windows:inventory --check remains a deterministic drift gate.

I also rechecked the surrounding Phase 0 changes: the Windows smoke remains isolated, uses the real Electron startup path, waits for the main-process readiness marker, and tears down the process tree; core.longpaths=true is scoped to Maka-owned Git invocations; POSIX mode/probe assertions are skipped only where Windows cannot represent the same contract.

All current CI checks pass and the PR is mergeable. I found no remaining blocking issue in this revision.

@jackwener
jackwener merged commit d662415 into apache:main Aug 4, 2026
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants