test(windows): establish support baseline - #2156
Merged
Merged
Conversation
37 tasks
liugddx
force-pushed
the
feat/windows-phase-0-baseline
branch
from
August 4, 2026 13:58
465b334 to
b60ce7c
Compare
liugddx
commented
Aug 4, 2026
liugddx
left a comment
Member
Author
There was a problem hiding this comment.
Re-reviewed at 7c9271b7.
The earlier blocking inventory gap is resolved:
findSkipExpressions()now scans across line boundaries instead of requiringskip:andprocess.platformon the same source line.- regression coverage includes both a multiline ternary and a multiline logical expression;
- the seven previously omitted declarations are now present in the generated inventory;
- the documented total is corrected from 59 to 66;
windows:inventory --checkremains a deterministic drift gate.
I also rechecked the surrounding Phase 0 changes: the Windows smoke remains isolated, uses the real Electron startup path, waits for the main-process readiness marker, and tears down the process tree; core.longpaths=true is scoped to Maka-owned Git invocations; POSIX mode/probe assertions are skipped only where Windows cannot represent the same contract.
All current CI checks pass and the PR is mergeable. I found no remaining blocking issue in this revision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2142.
Baseline results
EBUSYnpm test: does not exit within 10 minutes and leaves the workspace runner aliveThe failing storage and root-runner results are recorded diagnostic baselines for the next phase, not claims of full Windows support.
Validation
npm run windows:inventorynpm run test:scriptsnode scripts/windows-smoke.mjsgit diff --check