ci(windows): add non-blocking baseline lane - #2173
Conversation
6af297d to
859c56f
Compare
|
Thanks for adding a real Windows baseline while keeping it explicitly non-blocking. I checked the live run: native exit outcomes are preserved, the storage failure is visible in the summary, logs are uploaded, and the workflow remains fork-safe with read-only permissions. I found one gap in the residual-process evidence. The audit only treats a process as repository-owned when its command line contains Could we identify run-owned processes through the process tree, tracked PIDs, or another signal that does not depend on the workspace path appearing in the command line, and verify the tree after cleanup? The rest of the baseline workflow looks sound. |
859c56f to
5c3ed7c
Compare
5c3ed7c to
3948d5c
Compare
|
Thanks, this was a real gap. Fixed in The workflow now snapshots existing Node/Electron process identities as For any residual root, the audit expands the CIM snapshot through Validated on the updated upstream PR run: the audit reported |
Astro-Han
left a comment
There was a problem hiding this comment.
Thanks for addressing the residual-process ownership gap. I rechecked the updated workflow and the successful Windows run; this is good to merge.
One low-priority follow-up: ConvertFrom-Json may deserialize the ISO CreationDate into a DateTime, while the current-process side explicitly formats it with ToString('o'). A non-empty baseline could therefore produce different identity strings. This is not blocking for the current non-blocking hosted-runner baseline, but it would be worth normalizing both sides through the same identity formatter and covering a non-empty baseline fixture in a follow-up.
Summary
windows-latestbaseline lanePart of #2142 (Phase 1: continuous Windows correctness).
Current Windows baseline
The validated run reports:
The job remains non-blocking while the Phase 1 backlog is reduced. A green job conclusion does not hide step outcomes: the job summary records
${{ steps.<id>.outcome }}and complete logs are retained in thewindows-baselineartifact.Validation
node --test scripts/windows-test-inventory.test.mjs scripts/windows-baseline-workflow.test.mjsnpm run windows:inventorynpm run test:scripts