fix(runtime): keep PTY tool results JSON-safe - #2209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lastAlternateScreenfrom projected PTY output when it has no model-visible text instead of materializing the optional field asundefined.Verification
node --test packages/runtime/dist/__tests__/shell-run-tool-result.test.js(9 passed)npm run format:checknpm run lintnpm test -w @maka/runtime(3,156 passed, 9 skipped; 2 unrelated deep-research tests could not open a stale local storage build reporting schema 10 as newer than supported schema 9)Root cause
projectPtyOutputForModelproduced an ownlastAlternateScreen: undefinedproperty when a PTY had no alternate-screen text. The durable RuntimeEvent writer correctly rejects nestedundefinedbecause it cannot be represented losslessly in JSON, so a successfulStopBackgroundTaskside effect failed at the T2 outcome commit and left the turn failed.