fix(ui): preserve Astryx List accessible names - #2225
Merged
Conversation
Contributor
|
Thanks for this — the patch is minimal and correctly targeted, and I verified it end to end: Two non-blocking notes:
Nothing blocking — happy to approve. |
Astro-Han
approved these changes
Aug 5, 2026
cat0825
added a commit
to cat0825/maka-agent
that referenced
this pull request
Aug 5, 2026
Resolve patches/README.md conflict by keeping both sections: - our apache#2205 "New messages" indicator section - upstream apache#2225 Astryx List accessible-name section Verified the merged @astryxdesign/core patch still applies cleanly via patch-package --error-on-fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2189
Summary
Listseam soaria-labelis forwarded to the rootul/olaria-labelledbybehavior for headered listsWhy
@astryxdesign/coreListacceptsaria-labelby type, but at runtime it was dropped, leaving several desktop lists without accessible names.Validation
Impact
中文
关闭 #2189
概要
List的补丁缝,使aria-label能正确透传到根ul/olheader时的aria-labelledby行为不变patches/README.md中的说明原因
@astryxdesign/core的List类型层支持aria-label,但运行时未转发,导致桌面端 6 个列表在无障碍里没有可访问名称。验证
影响