chore: remove product Voice module end-to-end - #2426
Merged
Conversation
jackwener
force-pushed
the
chore/remove-voice-module
branch
from
August 7, 2026 10:22
a9067b1 to
609635c
Compare
Delete the unused desktop/product Voice stack entirely: STT, realtime coordinator, mic capture, settings, host ops, voiceAudio turn plumbing, microphone OS permission, package exports, and audio endpoint-role metadata. No migration or compatibility shims — treat the product as if Voice was never shipped.
jackwener
force-pushed
the
chore/remove-voice-module
branch
from
August 7, 2026 10:25
a3f1b21 to
c0bbb0d
Compare
jackwener
added a commit
that referenced
this pull request
Aug 7, 2026
main has been red on `knip --workspace apps/desktop` since #2425, with `format:check` red alongside it, which drags every open PR's typecheck job red too (PR CI runs the branch merged with main). The knip half is leftovers, not new decisions: - #2425 deleted the CSS-contract suites but kept their helpers, so `assertCssRuleDecls` and `parseCssBlocks` lost their only callers. Removing them orphans the whole scanning subtree behind them (`cssRuleBody`, `splitSelectorList`, `stripCssComments`, the postcss block walk and the `CssBlock` type), which goes with them; `postcss` was that subtree's only use in this workspace and leaves devDependencies. What the file still owes its callers is `REPO_ROOT` and `readAllRendererCss`, which stay. - #2426 removed the Voice module end-to-end, but `provider-connection-dialog` was reachable only from the deleted `voice-settings-page` and survived it. The format half is just the formatter over three files that landed without it: `tool-free-model-call.ts`, and `bootstrap-connections.ts` + `connection-store.test.ts` from #2431. No behaviour change in any of this.
jackwener
added a commit
that referenced
this pull request
Aug 7, 2026
) main has been red on `knip --workspace apps/desktop` since #2425, with `format:check` red alongside it, which drags every open PR's typecheck job red too (PR CI runs the branch merged with main). The knip half is leftovers, not new decisions: - #2425 deleted the CSS-contract suites but kept their helpers, so `assertCssRuleDecls` and `parseCssBlocks` lost their only callers. Removing them orphans the whole scanning subtree behind them (`cssRuleBody`, `splitSelectorList`, `stripCssComments`, the postcss block walk and the `CssBlock` type), which goes with them; `postcss` was that subtree's only use in this workspace and leaves devDependencies. What the file still owes its callers is `REPO_ROOT` and `readAllRendererCss`, which stay. - #2426 removed the Voice module end-to-end, but `provider-connection-dialog` was reachable only from the deleted `voice-settings-page` and survived it. The format half is just the formatter over three files that landed without it: `tool-free-model-call.ts`, and `bootstrap-connections.ts` + `connection-store.test.ts` from #2431. No behaviour change in any of this.
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused product Voice stack (desktop STT, realtime voice coordinator, mic capture, Voice settings, host voice ops, and
voiceAudioturn plumbing).Nobody uses this module, so this PR deletes the implementation surface and the architecture that only existed for it:
voice.tscontract,AppSettings.voice, capabilityvoice, microphone OS permissionvoice-service, ephemeralvoiceAudio/ native audio part pipelinevoice.*protocol ops,HostVoiceCoordinator,voiceOperationIdon turn startIntentionally kept
photo/voice/ sticker message handling)voice_transcriptcandidate source enumBase
Rebased onto latest
origin/main. Compile-checked forcore,storage,runtime,runtime-host,ui, and desktop (preload/main/renderer/storybook).Test plan
voice/voice-gatewaykeys to ModelsvoiceOperationId