test(storage): cover Windows session bundle metadata - #2449
Merged
Conversation
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Windows does not represent POSIX executable bits. The fixture's
chmod(0755)therefore leavesrun.shnon-executable in source metadata, so the codec correctly packs it as0644. Node also reports hydrated regular files with a synthesized0666mode on Windows. The previous test assumed POSIX metadata on every host.This change does not infer executability from file extensions and does not alter the Session Bundle codec contract.
Validation
npm run buildnpm run typecheckgit diff --checkTwo unrelated symlink tests require Windows symbolic-link privileges on this local machine; they are not the Session Bundle failure recorded by the Windows CI baseline.
Relates to #2142.