Skip to content

fix(desktop): place daily review selector below trigger - #2546

Merged
Astro-Han merged 1 commit into
mainfrom
fix/daily-review-narrow-overflow
Aug 9, 2026
Merged

fix(desktop): place daily review selector below trigger#2546
Astro-Han merged 1 commit into
mainfrom
fix/daily-review-narrow-overflow

Conversation

@Astro-Han

Copy link
Copy Markdown
Contributor

Summary

At the 480px window floor, the Daily Review analysis-model selector used Astryx Selector’s default selected-item overlay behavior, so the open popover could cover its trigger and violate the existing Storybook bounds contract.

Set the selector’s existing placement seam to below, matching the settings-row selector layout already used by the default permission control. This keeps the popup within the row/page bounds without shared CSS or parallel positioning logic.

Verification

  • Existing product-settings-pages--daily-review-model-selector-open-narrow @ floor geometry reproduced before the fix: trigger 446.98..466.98, popover 442.98..580.98 (overlap)
  • Focused built-Storybook smoke with the locked Playwright Chromium passed at 480px in light and dark: popup 472.98..610.98, below trigger 446.98..466.98
  • npm --workspace @maka/desktop run build-storybook
  • npm --workspace @maka/desktop run typecheck
  • npm run format:check
  • Full storybook-visual-smoke.mjs run reached and passed both target floor jobs on the baseline build; the overall run still reports the unrelated pre-existing design-system-icons--lucide-icons catalog render failure

Checklist

  • Tests cover the change and fail without it
  • Format, typecheck and the affected Storybook smoke pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Astro-Han
Astro-Han marked this pull request as ready for review August 9, 2026 02:41
@Astro-Han
Astro-Han merged commit 5ca13ab into main Aug 9, 2026
12 checks passed
@Astro-Han
Astro-Han deleted the fix/daily-review-narrow-overflow branch August 9, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant