fix(desktop): place daily review selector below trigger - #2546
Merged
Conversation
Astro-Han
marked this pull request as ready for review
August 9, 2026 02:41
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
At the 480px window floor, the Daily Review analysis-model selector used Astryx Selector’s default selected-item overlay behavior, so the open popover could cover its trigger and violate the existing Storybook bounds contract.
Set the selector’s existing
placementseam tobelow, matching the settings-row selector layout already used by the default permission control. This keeps the popup within the row/page bounds without shared CSS or parallel positioning logic.Verification
product-settings-pages--daily-review-model-selector-open-narrow @ floorgeometry reproduced before the fix: trigger446.98..466.98, popover442.98..580.98(overlap)472.98..610.98, below trigger446.98..466.98npm --workspace @maka/desktop run build-storybooknpm --workspace @maka/desktop run typechecknpm run format:checkstorybook-visual-smoke.mjsrun reached and passed both target floor jobs on the baseline build; the overall run still reports the unrelated pre-existingdesign-system-icons--lucide-iconscatalog render failureChecklist
Does this PR entail a change in behavior?