feat(desktop): unify native locale authority - #2686
Conversation
xxhZs
left a comment
There was a problem hiding this comment.
Blocking integration issue against current main: Runtime Host residency vocabulary has changed from automation to scheduled-task, but activityKey() in runtime-host-upgrade-copy.ts only recognizes automation. After resolving the current production-file conflicts, Scheduled Task residency would therefore fall through to Other background activity / 其他后台活动 instead of its own localized label. Please rebase onto current main, preserve the new subpath imports and current test-pruning decisions while resolving conflicts, add an explicit scheduled-task mapping/copy, and rerun CI. The locale authority, stale-read guard, and migrated native copy paths otherwise look sound.
f2ce67b to
42b129e
Compare
Astro-Han
left a comment
There was a problem hiding this comment.
Codex automated review
I traced the locale authority through settings effects, notifications, permission UI, Runtime Host prompts, the project picker, and Computer Use status UI at exact head 42b129e9537448ce9764ce7fdec7a9c418653640. The authority and stale-read guard are sound, and the scheduled-task mapping issue reported on an older head is fixed here.
One reproducible P2 remains in the live Computer Use tray surface; see the inline comment. I did not find a P0/P1 issue, unnecessary parallel locale authority, or a useful PR split. The checks for this head are green.
Disclosure: This is an automated review performed by Codex using delegated adversarial review passes and a final evidence check. It has not been independently verified by Astro-Han or another human reviewer, does not constitute human approval, and does not represent the final judgment of a human reviewer.
42b129e to
f063c20
Compare
|
Rebased on current main and addressed the live Computer Use tray locale update in f063c20. Could you please take another look? |
f063c20 to
10bead9
Compare
|
Caution Review failedAn error occurred during the review process. Please try again later. Comment |
Astro-Han
left a comment
There was a problem hiding this comment.
I reviewed exact head 10bead90dec85facf8457ed8b2f532c891245fcd, including the full diff, CI, merge state, and the resolved review history. I found no reproducible P0–P2 issue on the current head.
The problem definition is correct: native Desktop surfaces should resolve one effective locale instead of maintaining separate settings reads and fallbacks. The main-process authority, stale-read protection, domain-owned catalogs, and live Client-setting observation form a coherent and appropriately small solution. The earlier scheduled-task mapping and active Computer Use tray update findings are fixed.
One P3 lifecycle follow-up remains. While uiLocale is auto, changing the operating-system language does not notify an already materialized Computer Use tray menu; it keeps the old copy until another Computer Use event rebuilds it. This is a low-frequency stale-presentation case rather than an authority or data-integrity failure, so I do not consider it blocking. Rebuilding before menu presentation, or publishing system-language changes, would close it cleanly.
I found no useful PR split or parallel production state to remove.
Approved with that follow-up recorded.
Disclosure: Codex performed the read-only source, lifecycle, CI, test, and prior-feedback analysis. The human contributor remains responsible for independently verifying the final diff and owns the approval decision.
中文
当前 head 没有 P0–P2。Desktop native locale 已收敛到单一 authority。运行中切换系统语言时已有 tray 暂不刷新属于 P3 展示陈旧,不阻塞 Approve。
Summary
Fixes #2685
Part of #2672
Tests
中文对照
摘要
测试