feat(cli): add a TUI locale authority - #2691
Conversation
670248d to
2a008dd
Compare
Astro-Han
left a comment
There was a problem hiding this comment.
Codex automated review
I reviewed exact head 2a008dda1900e12ae8e2b7109c1a0a261620754f against #2554 and the stated CLI/TUI locale boundary. I found no specific, reproducible P0–P3 issues.
The CLI resolves the locale once for the interactive TUI and passes the same value through first-run and normal startup. The welcome surface, slash autocomplete, and /help share one typed catalog and command registry, while command tokens, non-interactive output, protocol behavior, and exit semantics remain unchanged. The focused CI checks for this head are green. This is a single coherent CLI/TUI slice; I did not find a useful deletion or split that would make it easier to verify.
Disclosure: This is an automated review performed by Codex using delegated adversarial review passes and a final evidence check. It has not been independently verified by Astro-Han or another human reviewer, does not constitute human approval, and does not represent the final judgment of a human reviewer.
2a008dd to
b2ba4bf
Compare
|
Caution Review failedAn error occurred during the review process. Please try again later. Comment |
b2ba4bf to
f3e9712
Compare
Astro-Han
left a comment
There was a problem hiding this comment.
I reviewed exact head f3e9712738f99aa2af957f6193092733d227f092, including the full diff, CI, merge state, prior reviews, replies, and review threads. I found no specific, reproducible P0–P3 issues.
The problem definition is sound: the TUI previously had no single locale authority, allowing the welcome message, slash autocomplete, and /help to use inconsistent languages. This change gives the CLI ownership of locale resolution, applies the POSIX environment precedence consistently, and passes one resolved locale through both normal and first-run TUI startup.
The implementation is also the smallest complete solution. The CLI owns its catalog, the command registry remains authoritative for command tokens, and Desktop settings are not introduced as a parallel source. Protocol values, machine-readable output, logs, and exit semantics remain unchanged. I did not find useful code or tests to delete, or a reason to split the PR.
Approved.
Disclosure: Codex performed the read-only source, lifecycle, test, CI, and prior-feedback analysis for this review. The human contributor remains responsible for independently verifying the final diff and owns the approval decision.
中文
最新 head 未发现 P0–P3。CLI locale authority 的归属、生命周期和测试都合理,没有引入 Desktop 依赖或平行状态;这是最小完整方案,可以 Approve。
Summary
MAKA_LOCALE=zh|en|auto, withautofollowingLC_ALL,LC_MESSAGES, thenLANG/helpshare the same CLI-owned catalogNo global
--localeoption is added.Testing
npm --workspace maka-agent run typechecknpm --workspace maka-agent test(358 tests)MAKA_LOCALEand locale-independent--helpFixes #2554
Part of #2672
中文对照
摘要
MAKA_LOCALE=zh|en|auto解析语言;auto依次遵循LC_ALL、LC_MESSAGES、LANG/help共用 CLI 自己维护的 catalog本 PR 不新增全局
--locale参数。验证
npm --workspace maka-agent run typechecknpm --workspace maka-agent test(358 项测试)MAKA_LOCALE以及不受 locale 影响的--help