docs: add DISCLAIMER-WIP for podling releases - #3141
Conversation
|
Warning Review limit reached
Next review available in: 2 minutes Limit details: You’ve used all 3 included reviews currently available under your plan. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 1 remains after this review. 📝 WalkthroughSummary
Source of truth and scopeThis change extends the existing release-artifact compliance process. It does not create a parallel runtime path. The change is the smallest coherent solution. It adds the required document, packages it with desktop releases, and adds one corresponding packaging check. The file should become Deletions and simplificationNo code or test can be deleted or simplified without weakening packaging coverage. The packaging assertion protects against release artifacts that omit the disclaimer. Risks and validation
Complexity delta
Review-relevant risks
WalkthroughAdded an Apache Incubator disclaimer that describes Maka’s incubation status, ASF compliance gaps, pending grants and ICLAs, licensing review requirements, and the project status URL. Packaged applications now include and verify the disclaimer. ChangesIncubator disclaimer
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The PR adds release-disclaimer documentation, and no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Adds an Apache Incubator–style DISCLAIMER-WIP file at the repository root so podling release artifacts can carry the required disclaimer while compliance items remain open (per #2974 Phase 3).
Changes:
- Introduces a
DISCLAIMER-WIPfile using standard Incubator disclaimer language. - Enumerates the current known blocking compliance items (license headers, NOTICE rework, grant/ICLAs).
- Links to the podling status page on the Incubator site.
Suppressed comments (1)
DISCLAIMER-WIP:23
- The file currently ends with an extra whitespace-only line. Removing it avoids trailing whitespace in the repository.
https://incubator.apache.org/projects/maka.html
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
likun666661
left a comment
likun666661
left a comment
There was a problem hiding this comment.
The file should be synchronized with the current Work In Progress Disclaimer in the Incubator policy before merge. The policy currently uses at The Apache Software Foundation, decision-making process, and What follows is a list of issues ... (this list is likely to be incomplete), while this file uses different wording in each place. The policy also says a different disclaimer message requires IPMC approval, so copying the current template verbatim avoids a release-vote blocker. The previously resolved thread cites the same page, but the live page currently shows the hyphenated WIP wording: https://incubator.apache.org/policy/incubation.html#work-in-progress-disclaimer. The Maka status URL itself is now live and correct.
|
You are right, and my earlier reply on the hyphenation thread was wrong. I verified against the standard podling disclaimer and did not notice the policy publishes the Work In Progress Disclaimer separately, with its own wording. Checking a template other than the one the file is named after is exactly the mistake to catch here — thanks for the pointer to the anchor.
Only the three known-issue bullets are ours; everything else is byte-for-byte the published template, which I diffed rather than eyeballed. That also settles the point about needing Incubator PMC approval for a different message — there is no longer anything different to approve. Good to hear the status URL resolves. That was the one open question in the description, so it can be treated as closed. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
DISCLAIMER-WIP:4
- The Incubator policy/template text uses “decision making process” (no hyphen). Keeping this line verbatim avoids release-vote nits and also matches the prior resolution in the existing review thread.
infrastructure, communications, and decision-making process have stabilized in
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (2)
DISCLAIMER-WIP:4
- The standard Incubator DISCLAIMER(-WIP) wording uses “decision making process” (no hyphen). Keeping this line verbatim with the template helps avoid release-vote nits and aligns with the Incubator policy text.
infrastructure, communications, and decision-making process have stabilized in a
DISCLAIMER-WIP:10
- “un-reviewed” is nonstandard in ASF templates (typically “unreviewed”). Aligning spelling here reduces the chance of downstream compliance/style feedback during the vote.
policy. For example, releases may have incomplete or un-reviewed licensing
|
Thanks for the file — I verified it against the live Incubator policy and the issue state, and the file itself is correct. A few notes to help close the review: On the open CHANGES_REQUESTED (wording sync): I diffed the file against the current policy text at The three known-issue bullets check out against #2974's actual state: no source file in The status URL concern is moot — One real gap (P2, actionable or deferrable): desktop binary releases won't carry the DISCLAIMER-WIP. AI-assisted review disclosure: this review was produced with AI assistance (pi review subagent on 中文摘要（AI 辅助审查）结论：PASS（1 个 P2，可接线或显式延后）。文件本体正确：(1) 关于 likun666661 的 CHANGES_REQUESTED（措辞与 policy 同步）——逐字比对实时政策页（incubator.apache.org/policy/incubation.html 的 Work In Progress Disclaimer 段），本 PR 的 "at The Apache Software Foundation"、"decision-making process"（带连字符）、"What follows is a list of issues..." 与实时模板 verbatim 一致（无连字符版本是 xtable 等旧文件，实时政策页才是权威）——当前措辞方向正确，request 可能基于旧模板；(2) 三个已知项全部属实（全仓源码无 ASF license header（grep 0 命中）、NOTICE 仍是 "Copyright 2026 The Maka Authors"、grant/ICLAs 未勾选），无遗漏/无误列；(3) status URL 已上线（podling maka 已注册 2026-08-13），PR 描述中 PODLINGNAMESEARCH 顾虑已过时（P3）。唯一实质缺口（P2）：electron-builder.config.mjs 的 extraResources 显式打包 LICENSE/NOTICE 但没有 DISCLAIMER-WIP——二进制发布物会缺必需文件，建议补一行接线或显式记录延后理由（首个 Apache 发布尚在 1-3 个月后、源码发布不受影响、当前桌面发布非 Apache 渠道）。 |
Part of apache#2974. Every podling release artifact must carry a DISCLAIMER, and the WIP variant is what the Incubator expects while known compliance items are still open — it names them instead of asserting a compliance the project does not yet have. The three listed items are the remaining blocking entries from that issue (license headers, NOTICE rework, grant and ICLAs), so this file and the checklist stay in step. Each should be struck from here as it lands, and the file renamed to DISCLAIMER once the list is empty. The Incubator status URL assumes the podling name `maka`; it needs updating if PODLINGNAMESEARCH lands on a different one. Claude-Session: https://claude.ai/code/session_014ajaRxC4jydavY9nYUFj5J
The file used the standard podling disclaimer's wording under a WIP filename. The Incubator publishes the two separately and they differ: "at The Apache Software Foundation", "decision-making process" hyphenated, and "a list of issues the project is currently aware of (this list is likely to be incomplete)". Since the policy requires Incubator PMC approval for any disclaimer that is not the published template, matching it verbatim is what keeps this off the release-vote agenda. Only the known-issues list is ours. Claude-Session: https://claude.ai/code/session_014ajaRxC4jydavY9nYUFj5J
The template's sponsor field is a placeholder for the sponsoring TLP. A podling entering through the Incubator itself fills it with "the Apache Incubator PMC" — graphar, devlake and seata all word it that way. The file said "the Apache Incubator", which names the project rather than the body that sponsors it. Re-wrapped to 80 columns after the substitution. The prose is still byte-for-byte the published Work In Progress Disclaimer once the placeholders and the known-issues list are substituted; verified against the policy page's markup rather than a rendering of it. Claude-Session: https://claude.ai/code/session_014ajaRxC4jydavY9nYUFj5J
4264f3f to
c948c33
Compare
|
Both addressed. Rebased onto [P1] The disclaimer was not reaching the release artifacts. Correct, and the more important of the two — a Verified rather than assumed: built the macOS arm64 app, confirmed Wording. Already matches the current Work In Progress Disclaimer verbatim on this head; the earlier round fixed it after you pointed out I had been checking against the Standard Disclaimer. Re-verified against the live policy page just now: it carries both templates, and the strings differ exactly where you said — Not run locally: the Windows packaging path. It goes through the same |
Incubator policy requires every release archive to carry a DISCLAIMER or DISCLAIMER-WIP. Adding the file at the repository root did not reach the packaged app: electron-builder copies LICENSE and NOTICE into licenses/maka and nothing else, so the DMG, the ZIP and the Windows installer all shipped without it. Map it alongside LICENSE and NOTICE, and require it in assertPackagedResources so both the macOS and Windows verifiers fail if it ever stops being packaged. Generated-by: Claude Code
c948c33 to
316d9a0
Compare
|
CI caught a real problem with the first attempt, fixed in the amended commit. Requiring
This was not reachable locally — I do not have the 0.1.9 Windows installer — so it is a genuine catch by the pipeline rather than something I skipped. |
|
Confirmed — all addressed: the DISCLAIMER-WIP now ships via AI-assisted review disclosure: this review was produced with AI assistance; the human contributor reviewed the final diff and the Incubator wording. Please weigh these findings with your own judgment. |
Both concerns addressed by the author in later commits: wording now matches the Incubator WIP policy verbatim (verified against incubator.apache.org/policy/incubation.html#work-in-progress-disclaimer), and the DISCLAIMER-WIP packaging + verifier wiring was added (8/18). Dismissing as resolved.
|
合并后复盘补充：DISCLAIMER-WIP 正文、三条 known issues，以及 Desktop 的 DMG/ZIP/Windows installer 接线都已正确；但 merge 时 main 刚加入了真实 npm CLI 发布链，当前合并结果遗漏了这个发布面，需要跟进修复。 P1：npm CLI tarball 不包含 当前 main：
因此从当前 revision 构建的下一版 CLI 包会缺免责声明。Apache Incubator policy 要求 podling 的 releases/documentation 携带 incubating disclaimer，并建议 release 中的 DISCLAIMER-WIP 与 LICENSE/NOTICE 同置。 建议补一个小 PR：
这是合并后父线新增 CLI release surface 才显现的遗漏，不否定本 PR 对 Desktop 发布物的修复；但在下一个 podling CLI release 前必须补齐。 |
|
@hqhq1025 — the CLI-tarball gap is fixed in #3220, covering the four seams you listed: the staging copy, the npm files whitelist plus the staging and packed-files assertions, the validation workflow's path filters, and an installed-package check in the offline smoke. Verified by building the tarball under the pinned toolchain (it carries |
Apache Incubator policy requires podling releases to carry the incubating disclaimer, and #3141 wired it into every desktop artifact — but the npm CLI publication chain landed on main in parallel, so the next CLI tarball would have shipped without it. The staging copy step now places DISCLAIMER-WIP next to LICENSE/NOTICE, the npm files whitelist and the staging/packed-files assertions require it, the installed-package smoke checks it end to end, and the CLI package validation workflow triggers on changes to the disclaimer itself. Reported by @hqhq1025 in the #3141 post-merge review. Generated-by: Claude Code
Part of #2974 (Phase 3, Add a
DISCLAIMERfile).Every podling release artifact has to carry a DISCLAIMER. The
-WIPvariant is the one the Incubator expects while compliance items are still open: it enumerates what is not yet satisfied rather than asserting a compliance the project does not have yet.The three known-issue bullets are exactly the remaining blocking entries on the checklist — license headers, NOTICE rework, grant/ICLAs — so this file and the issue stay in step. The intent is that each is struck from here as it lands, and the file is renamed to
DISCLAIMERonce the list is empty.One thing to confirm: the Incubator status URL assumes the podling name
maka. If PODLINGNAMESEARCH lands somewhere else, this line needs to follow. I left it pointing at the expected path rather than omitting it, since a missing status link is itself a review comment during the release vote — but say the word and I will drop it until the name clears.Text follows the Incubator's standard DISCLAIMER-WIP wording. No code paths touched; lint and format pass.