refactor(desktop): remove superseded local authority paths - #3252
Conversation
Delete obsolete Desktop chat admission, Git Review mutation, store-backed config export, and direct ArtifactStore attachment paths now that Runtime Host owns those boundaries. Preserve the live compatibility projection and move config/attachment security coverage to the authoritative paths. Generated-by: Codex
Astro-Han
left a comment
There was a problem hiding this comment.
Approved exact head a349227f70ab369f26aab8d97ab0a7b28db6fcc2.
I verified that the removed Desktop paths are superseded and have no remaining production callers, while Runtime Host attachment ingestion, historical attachment/session reads, config import/export, read-only Git Review, and model admission remain intact. The new boundary tests cover the retained Host-owned behavior. I found no P0–P3 issue.
The PR body and sole commit provide complete Codex disclosure/provenance. The renderer change is comment-only, so there is no UI/UX screenshot requirement. This approval is not a merge-readiness statement until the remaining queued required checks finish green.
AI-assisted review disclosure: OpenAI Codex performed the exact-head deletion-safety, call-site, compatibility, provenance, and CI analysis; I verified the retained authority paths and live GitHub state before approving.
中文说明
已确认删除的都是被 Runtime Host 取代且无生产调用的旧路径;附件、历史读取、配置导入导出、只读 Git Review 与模型准入仍保留,没有 P0–P3。AI provenance 合规,也没有实际 UI 变化。剩余 required checks 全绿后才能视为 merge-ready。
Summary
Remove four Desktop-local authority paths superseded by Runtime Host, for a net deletion of 1,154 lines:
ArtifactStoreattachment wrapper and workspace-reference mode so the sole live path snapshots every attachment through Runtime Host.The implementation keeps import behavior, read-only Git Review, onboarding health/readiness projection, and the live attachment/config security boundaries intact.
Verification
npm --workspace @maka/desktop run build:workspace-depsnpm --workspace @maka/desktop run typechecknpm --workspace @maka/desktop run build:mainnpx biome checkon all 17 modified non-deleted source/test filesgit diff --checkThe broad test suite was not run locally; hosted CI remains the full merge gate.
Security review focus
The attachment byte-cap/TOCTOU assertion now exercises
resolveAttachmentRefs, the live Host snapshot boundary, before any artifact creation. Config export tests now exercisegatherRuntimeHostConfigand verify that settings secrets are omitted unless credentials are selected, while selected proxy, Tavily, and connection credentials come from Runtime Host authority.AI use
Select exactly one:
Tool(s) and scope: Codex audited production call sites, implemented the authority-path deletions, moved focused security coverage, and performed local verification.
Checklist
Does this PR entail a change in behavior?