feat(ui): add Storybook renderer baseline - #370
Merged
Conversation
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a renderer-aligned Storybook baseline for Maka UI primitives.
Why
Tracks #363. This gives frontend file-governance work an isolation gate: extracted primitives can be mounted outside the app shell while still using the renderer's Vite, Tailwind, CSS, token, and theme substrate.
Scope
Changed:
@maka/desktopStorybook scripts and dev dependencies:storybookand@storybook/react-vite..storybook/main.tswith React+Vite, Tailwind v4, and@maka/uisource aliases matching the renderer setup..storybook/preview.tsxthat imports rendererstyles.cssand provides light/dark plus palette root decorators.packages/uiwith a small primitive story fixture coveringButton,Alert,Empty, andSpinner.build/testwhile pinning the baseline setup.Not included:
packages/uistories.Verification
npm run -w @maka/desktop build-storybooknpm run -w @maka/desktop typechecknpm run -w @maka/desktop buildcd apps/desktop && node --test "dist/main/**/*.test.js"→ 1621/1621 passingnpm run -w @maka/desktop build:main && cd apps/desktop && node --test dist/main/__tests__/storybook-baseline-contract.test.jshttp://127.0.0.1:6006/index.jsonincludesPrimitives/Storybook BaselineUser-facing impact
None. This is dev tooling only; desktop app runtime and production build behavior are unchanged.
Reviewer notes
npm run -w @maka/desktop testcurrently stops inpretestatscripts/check-console.mjsbecausepackages/headless/src/harbor-cli.tshas pre-existingconsole.errorcall sites. The desktop node test suite itself passes when run fromapps/desktopafterbuild:main.npm auditreports 4 advisories against current direct/transitive tooling dependencies (vite,undici,esbuild,@babel/core). This PR does not broaden into dependency remediation.