refactor(ui): extract non-chat component groups - #372
Merged
Conversation
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the non-chat dependency groups from
packages/ui/src/components.tsxinto focused sibling modules while keeping the public@maka/uisurface stable throughcomponents.tsxre-exports.Move map:
nav-selection.ts:NavSelection/SessionFiltermodal-a11y.ts:useModalA11ytool-format.ts: tool formatting helpersempty-state.tsx:EmptyStatecapability-audit-strip.tsx:CapabilityAuditStripsearch-modal.tsx:SearchModalsession-list-panel.tsx:SessionListPanel+ row/group helperstool-activity.tsx:ToolActivity,OverlayHost, preview surfaces,formatBytespermission-dialog.tsx:PermissionDialog+ permission summary helpersmodule-panel-types.ts: shared sidebar/module panel typesWhy
Refs #363. This is PR2 from the sink-file split plan: cut unrelated non-chat UI responsibilities out of
components.tsxwithout changing runtime behavior or visual output.Scope
Changed:
packages/ui/src/*sibling modules for the extracted non-chat groups.components.tsxas the compatibility re-export point, sopackages/ui/src/index.tsand existing consumers continue to work.toast.tsxto importuseModalA11yfrom the leaf module to avoid acomponents.jsback-edge.Not included:
ChatView,Composer, Settings,main.tsx, Storybook, CSS, or visual redesign work.Verification
npm run -w @maka/ui buildnpm run -w @maka/desktop build:mainnpm run -w @maka/desktop typechecknpm run -w @maka/desktop buildnode scripts/check-a11y.mjsnpm run buildKnown unrelated blocker:
npm run -w @maka/desktop testcurrently stops in pretest on the existingcheck-consolegate forpackages/headless/src/harbor-cli.tsconsole calls.User-facing impact
None expected. This is intended to be behavior- and visually-neutral. No
CHANGELOG.md, docs, breaking changes, or migrations.Reviewer notes
Cycle guard checked the new UI leaf files for imports from
@maka/ui,./index.js, or./components.js; no matches.components.tsxstill re-exports the moved declarations so the public API remains intact until the later chat extraction slice.