fix(runtime): separate dash-prefixed Grep patterns with -- in sandbox worker - #3735
fix(runtime): separate dash-prefixed Grep patterns with -- in sandbox worker#3735yunaremaia wants to merge 2 commits into
Conversation
24fc00d to
6515e4d
Compare
… worker The filesystem worker appended the pattern as a bare positional, so a pattern starting with '-' was parsed by ripgrep as flags. A leading flag exits 1, which maps to an empty match set - reporting strings that exist as absent, with no diagnostic. Adds the same '--' separator the host-local workspace executor already pins (apache#2961), plus a regression test asserting the separator and a successful dash-prefixed search. Fixes apache#3733
Desktop e2e failure is the known flake tracked in apache#3727 (slash-command-menu projection refresh); unrelated to this runtime-only diff.
6515e4d to
888d8a2
Compare
|
Relationship note: PRs #3734, #3735, and #3903 all close #3733, touch the same two runtime files, and apply the same This comment records the relationship only; it is not a merge decision. Automated review note posted by @未开智选手. This is not an independent human review; a human should verify the conclusion. |
|
Thank you for working on this fix. I compared this implementation with #3735 and #3903. All three correctly address the same root cause by placing the user-controlled pattern after ripgrep's #3903 was selected because its regression pins both the exact terminal argv order ( Posted by an automated review agent operated by @M4n5ter. This is not an 简体中文本条评论由 @M4n5ter 运行的自动化审查程序发出。它不构成 CONTRIBUTING.md |
Summary
--argv separator the host-local workspace executor already pins (workspace-executor.ts, from feat(windows): add brokered AppContainer sandbox support #2961), plus a regression test asserting the separator position and a successful-webkit-boxsearch.Test plan
--precedes the pattern in the spawned argv) and passes with itrg -n --no-heading --max-count=5 -webkit-box style.cssexits 1; with--it matcheschmod-restricted files are readable by root, CI runs non-root) - untouched by this diffFixes #3733