refactor(desktop): split provider settings flows - #377
Merged
Conversation
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split
ProvidersPanel.tsxinto focused provider settings sibling files while keeping the existing facade exports stable.Why
Part of #363
ProvidersPanel.tsxhad accumulated provider catalog, OAuth login, config sheet, add form, connection detail, and model table behavior in one sink file. This keeps the runtime behavior in place but moves each flow to the file that owns it.Scope
Changed:
ProvidersPanel.tsxas the facade forConnectionsBridge,ProvidersPanel,ProviderLogo, andproviderDisplay.provider-catalog.tsx,provider-oauth-section.tsx,provider-config-sheet.tsx,provider-add-form.tsx,provider-connection-detail.tsx,provider-display.tsx, andprovider-panel-shared.ts.provider-contract-source-helpers.tsso the tests read the new provider source files instead of assuming one large file.ProvidersPanel.tsx -> ModelOAuthSectionlocation.Not included:
Verification
node ../../worktree-bootstrap.mjsnpm run -w @maka/desktop typechecknpm run -w @maka/desktop buildnode --test dist/main/__tests__/model-oauth-section-contract.test.js dist/main/__tests__/claude-subscription-experimental-gate.test.js dist/main/__tests__/settings-confirm-dialog-contract.test.js dist/main/__tests__/settings-form-a11y-contract.test.js dist/main/__tests__/settings-roadmap-cleanup-contract.test.js dist/main/__tests__/web-search-boundary.test.js dist/main/__tests__/session-sticky-model-contract.test.jsnode --test dist/main/__tests__/storybook-baseline-contract.test.jsAttempted:
npm run -w @maka/desktop testcurrently fails ondaily-review-copy-feedback-contract.test.js(onCopyDailyReviewMarkdown?(input:)source-grep expectation). I reproduced the same failure on cleanmain, so it is not introduced by this PR.User-facing impact
None expected. This is a source organization refactor; existing provider settings UI and facade imports remain stable.
Reviewer notes
The PR intentionally keeps source-reading contracts lightweight: provider tests can read named provider source files and still use
combinedwhere the existing contract spans multiple provider flows.