Skip to content

test(ui): add command search stories - #402

Merged
Astro-Han merged 2 commits into
mainfrom
codex/storybook-command-search
Jul 1, 2026
Merged

test(ui): add command search stories#402
Astro-Han merged 2 commits into
mainfrom
codex/storybook-command-search

Conversation

@Astro-Han

Copy link
Copy Markdown
Contributor

Summary

Adds Storybook state coverage for the command palette and content search modal as the PR4 slice of the #390 keyboard/modal family work.

Why

Part of #390.

Scope

Changed:

  • Adds desktop renderer stories to the Storybook glob.
  • Adds command/search stories covering command palette grouped, empty, disabled, keyboard-focused, loading, results, error, and privacy-blocked states.
  • Adds search modal stories covering empty, loading, results, no-results, error, and privacy-blocked states.
  • Adds a narrow injectable search deps seam for CommandPalette stories while keeping the live preload bridge as the default.
  • Extends the Storybook baseline contract for PR4 coverage.

Not included:

  • Visual polish or CSS changes.
  • Settings / PR5 story coverage.
  • Runtime, storage, Electron main, or preload behavior changes.

Verification

  • npm run -w @maka/desktop build:main && node --test apps/desktop/dist/main/tests/storybook-baseline-contract.test.js
  • npm run -w @maka/desktop build-storybook
  • npm run typecheck
  • npm run -w @maka/desktop build
  • npm run -w @maka/desktop test
  • Storybook dev index check: 14 Product/Command Search stories registered on local port 6007

User-facing impact

No runtime user-facing change. Storybook-only state coverage for review before visual polish.

Reviewer notes

The command palette seam is intentionally narrow: stories can inject search deps, while production still defaults to window.maka.search.thread through the existing hook.

@Astro-Han
Astro-Han force-pushed the codex/storybook-command-search branch from 830f51a to 39397de Compare July 1, 2026 10:31
@Astro-Han
Astro-Han merged commit ab27235 into main Jul 1, 2026
@Astro-Han
Astro-Han deleted the codex/storybook-command-search branch July 1, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant