refactor(ui): tighten design system governance - #416
Merged
Conversation
Contributor
|
Pushed c1b80dc with the review-response changes. Covered:
Verified with |
- Redesign Colors story: semantic groups (base colors, emphasis aliases, foreground scale) with usage annotations per swatch - Fix Radius story: preview blocks were white-on-white (invisible in light mode); switch to foreground-filled blocks with contrast text - Redesign PrimaryActions story: cover all 6 variants, disabled states, and size+icon combinations instead of only 3 variants - Darken --action (L 0.52 → 0.46) to separate from --control (L 0.52), giving three distinct greens: accent (garnish) > control (checked) > action (CTA) - P2: narrow radius test name from 'single radius token vocabulary' to 'radius tokens for preview card surfaces' — reflects actual coverage - P3: fix motion allowlist substring match (includes) to exact match (Set.has) so 'maka-pulse-enter-card' is correctly rejected - P3: remove snapshot-lite assertions from storybook baseline contract (wordBreak, gridTemplateColumns, fontSize, '6px', 'Action primary')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
control,surface,modal, andpill, with the 12px ceiling documented.Tests
npm run typechecknpm --workspace @maka/ui testnpm --workspace @maka/desktop run build-storybooknpm --workspace @maka/desktop run build:main && node --test apps/desktop/dist/main/__tests__/design-system-governance-406-contract.test.js apps/desktop/dist/main/__tests__/ chat-preview-cascade-contract.test.js apps/desktop/dist/main/__tests__/chat-tool-card-cascade-contract.test.js apps/desktop/dist/main/__tests__/radius-converge-contract.test.js apps/desktop/dist/main/__tests__/motion-token-converge-contract.test.jsnpm test