test(desktop): sync copy-feedback contract to the --link semantic token - #451
Merged
Conversation
#441 split --accent into semantic roles and moved the copied-state feedback color at both call sites (primitives/chat.tsx footer action, tool-activity.tsx error banner) to var(--link), but the visible-copy-hygiene contract still asserted var(--accent), leaving main red (2 failures). Sync the two assertions to the semantic token actually in the source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main is currently red (2 failures in
visible-copy-hygiene-contract): #441 moved the copied-state feedback color tovar(--link)at both call sites but the contract still assertsvar(--accent). This syncs the two assertions to the token actually in source.npm --workspace @maka/desktop test: 1685/1685 after this fix (was 1679/2).